Skip to content

Docs/expression restrictions#312

Merged
bfolie merged 4 commits intomasterfrom
docs/expression-restrictions
Apr 24, 2020
Merged

Docs/expression restrictions#312
bfolie merged 4 commits intomasterfrom
docs/expression-restrictions

Conversation

@bfolie
Copy link
Copy Markdown

@bfolie bfolie commented Apr 23, 2020

Citrine Python PR

Description

The ExpressionPredictor documentation did not include a list of supported items.

This PR also updates it so that there is 1 sentence per line.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in setup.py

@bfolie bfolie requested review from kroenlein and latture April 23, 2020 22:21
Copy link
Copy Markdown
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes for consistency.

Comment thread docs/source/workflows/predictors.rst Outdated
Comment thread docs/source/workflows/predictors.rst Outdated
bfolie and others added 2 commits April 23, 2020 19:50
Co-Authored-By: Ken Kroenlein <51962276+kroenlein@users.noreply.github.com>
Co-Authored-By: Ken Kroenlein <51962276+kroenlein@users.noreply.github.com>
@bfolie bfolie merged commit 3de903a into master Apr 24, 2020
@maxhutch maxhutch deleted the docs/expression-restrictions branch April 24, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants