Add LabelFractionPredictor with tests#332
Conversation
|
@genfx999 We're renaming this predictor |
|
Sorry for the last minute rename. I'll go ahead and push the changes. We can revert later if needed. Overall, this PR was nearly perfect. The class and tests were great. There were only two minor things missing. We need to add the class to the map in |
|
@latture We good to merge this to formulations branch? |
|
We just need to add user docs. I'll write those this morning. |
|
@gregor-robinson @maxhutch Would one of you be able to do a quick review of this PR? I've reviewed it, and it looks good to me. However, I've pushed enough code to resolve merge conflicts with the feature branch it was based off of that a second pair of eyes would be good. |
maxhutch
left a comment
There was a problem hiding this comment.
I made one non-blocking suggestion on documentation language. Looks good, though.
Co-authored-by: Max Hutchinson <maxhutch@gmail.com>
Citrine Python PR
Description
https://citrine.atlassian.net/browse/PLA-3759
PR Type:
Adherence to team decisions