Skip to content

Boost gemd-python dependency to 1.2 and add support#691

Merged
kroenlein merged 3 commits intomainfrom
support-gemd-1-2
Oct 6, 2021
Merged

Boost gemd-python dependency to 1.2 and add support#691
kroenlein merged 3 commits intomainfrom
support-gemd-1-2

Conversation

@kroenlein
Copy link
Copy Markdown
Collaborator

@kroenlein kroenlein commented Oct 6, 2021

Citrine Python PR

Description

As per PLA-8254, this integrates the new equality checks from gemd-python.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in setup.py

@kroenlein kroenlein requested a review from maxhutch October 6, 2021 19:24
@kroenlein
Copy link
Copy Markdown
Collaborator Author

Copy link
Copy Markdown
Contributor

@maxhutch maxhutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kroenlein kroenlein merged commit 43bde84 into main Oct 6, 2021
@kroenlein kroenlein deleted the support-gemd-1-2 branch October 6, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants