convert batch_size into a package constant #779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Description
The current hypothesis is that sometimes the objects we send to datasvc are so big that they cause a time-out during writing. @kenneth Kroenlein One workaround for this is to reduce the batch-size configuration in citrine-python/gemd_resource.py from 50 to a lower value.
https://citrine.atlassian.net/browse/PLA-10156
To address the user pain point, we should change batch_size = 50 to a package constant BATCH_SIZE = 50 so that users can handle this case without editing citrine-python source code.
PR Type:
Adherence to team decisions