PLA-10206: User configure auto ml #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfriedowitz
commented
Aug 31, 2022
| # We never exposed saving a model without training, so we should | ||
| # continue to do it automatically. | ||
| return self._train(predictor.uid) | ||
| # If the initial response is invalid, just return it |
Contributor
Author
There was a problem hiding this comment.
@anoto-moniz We will never actually hit the .failed() branch until the API bug fix is in, but the logic is correct and tested for now.
kroenlein
reviewed
Aug 31, 2022
Collaborator
kroenlein
left a comment
kroenlein
left a comment
There was a problem hiding this comment.
I didn't see a test verifying that an arbitrary string is not a valid AutoMLEstimator. Intentional?
added 3 commits
August 31, 2022 16:23
kroenlein
approved these changes
Sep 1, 2022
Collaborator
kroenlein
left a comment
kroenlein
left a comment
There was a problem hiding this comment.
LGTM. Get an e2e in there when you get a chance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Adds support to configure estimator types for AutoML.
PR Type:
Adherence to team decisions