Conversation
bfolie
reviewed
Oct 7, 2021
| elif isinstance_reversible(this): | ||
| queue.extend(reversed(this)) # Preserve order of the list/tuple | ||
| elif isinstance_iterable(this): | ||
| queue.extend(this) # Preserve order of the list/tuple |
There was a problem hiding this comment.
What's an example of a non-reversible iterable, and how does this preserve order?
Collaborator
Author
There was a problem hiding this comment.
An example would be a set. The comment was accidental copy-pasta.
bfolie
previously approved these changes
Oct 7, 2021
bfolie
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Friction has been observed where
recursive_foreachandrecursive_flatmapbehave badly on list-like elements such as dist_keys. This corrects those methods behavior.