Skip to content

Update Travis to test up to 3.10#162

Merged
kroenlein merged 3 commits intomainfrom
feature/python-3-10
Jan 7, 2022
Merged

Update Travis to test up to 3.10#162
kroenlein merged 3 commits intomainfrom
feature/python-3-10

Conversation

@kroenlein
Copy link
Copy Markdown
Collaborator

Python 3.10 is currently considered stable, so we should be testing against it. This augments the tests that Travis runs to do this, and propagates the need to support Python 3.10 to required packages.

@kroenlein
Copy link
Copy Markdown
Collaborator Author

Almost 12 minutes is required for 3.11-dev to build pandas, which is required for 2 tangential tests. This may motivate dropping 3.11-dev from the proposed suite of tests.

@bfolie
Copy link
Copy Markdown

bfolie commented Jan 6, 2022

Almost 12 minutes is required for 3.11-dev to build pandas, which is required for 2 tangential tests. This may motivate dropping 3.11-dev from the proposed suite of tests.

I agree. It's highly unlikely that our customers are using the in-development version of python, and we can cross any relevant bridges when it is officially released.

Comment thread .travis.yml Outdated
Comment on lines +8 to +9
- '3.10.0'
- '3.10.1'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why explicitly test both 3.10.0 and 3.10.1?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there is no Travis option for just 3.10; only 3.10.0, 3.10.1 and 3.10-dev. I'm okay with dropping 3.10.0 but had it in there because conda doesn't have a 3.10.1 build yet so I wanted to be able to make sure that anything that went wrong was not because of a 3.10.0 v. 3.10.1 difference.

https://docs.travis-ci.com/user/languages/python/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, nothing went wrong with 3.10.1, correct?

Comment thread .travis.yml
language: python
dist: bionic
python:
- '3.6'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weren't we going to drop 3.6?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of our customers is currently using 3.6 to run their ingest pipeline. The customer team is following up to understand why that is, but so long as it is we need to support it.

@kroenlein kroenlein requested a review from bfolie January 6, 2022 22:59
@kroenlein kroenlein merged commit bf71901 into main Jan 7, 2022
@kroenlein kroenlein deleted the feature/python-3-10 branch January 7, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants