Add support for scaling factors to gemd-python#180
Merged
Conversation
Collaborator
Author
|
pint > 0.18 requires unit names be valid identifiers. Moved the munged version to first position in the definition statement, which unfortunately means that the pretty format isn't as pretty as it might be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pint does not support scaling factors in units (e.g., support ticket). In order to provide support for units encountered in the wild (e.g.,
g / 2.5 cm), this PR adds support for strictly numeric scaling factors.It dynamically adds a dimensionless scaling unit for any number encountered (where
Numberis defined using the same tokenizer as the core Pint library). Multiplication between a scaling factor and a unit also bind tighter than division (i.e., if that scaling factor is preceded by division and followed by a unit, it also puts that unit in the denominator).Internal Citrine reference: https://citrine.atlassian.net/browse/PLA-6256