Setting up testing for the repository#18
Merged
Merged
Conversation
fnattino
commented
Aug 28, 2024
cforgaci
reviewed
Aug 28, 2024
Contributor
cforgaci
left a comment
There was a problem hiding this comment.
Looks good, thanks! I left a couple of comments on the use of functions.
cforgaci
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the repository should include enough data not to make queries to the Overpass API while running continuous integration. We should probably be storing the data in a form that is as close as possible to the way in which raw (OSM) data is provided, in order to test functionality of the cleaning steps. We should also consider storing cleaned data later on (e.g. cleaned street network), in order to test the functionalities of the steps that follows.
unless they are specifically flagged to run(EDIT: there is a nicetestthatfunctionality which suppresses tests on CI:skip_on_ci) - include example of a test that needs to be skipped.Closes #12.