Cache download data#75
Merged
Merged
Conversation
fnattino
commented
Feb 17, 2025
This is to be able to call it without cache being written
fnattino
commented
Feb 18, 2025
fnattino
commented
Feb 18, 2025
cforgaci
requested changes
Feb 18, 2025
Contributor
cforgaci
left a comment
cforgaci
left a comment
There was a problem hiding this comment.
Super! I pointed out two issues, one related to the use of warning() when writing to cache and the other related to a few failed osmdata tests.
Co-authored-by: Claudiu Forgaci <33600128+cforgaci@users.noreply.github.com>
Co-authored-by: Claudiu Forgaci <33600128+cforgaci@users.noreply.github.com>
Co-authored-by: Claudiu Forgaci <33600128+cforgaci@users.noreply.github.com>
Co-authored-by: Claudiu Forgaci <33600128+cforgaci@users.noreply.github.com>
Contributor
Author
|
Hi @cforgaci, thanks for the useful comments, I have hopefully addressed those. Can you have a final look and potentially confirm whether all tests succeed locally on your system as well? |
cforgaci
approved these changes
Feb 19, 2025
Contributor
cforgaci
left a comment
cforgaci
left a comment
There was a problem hiding this comment.
Looks good. All tests pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62