Skip to content
This repository was archived by the owner on Feb 17, 2024. It is now read-only.

Fix logged group name in reinforcement check#48

Merged
wingzero54 merged 2 commits intoCivMC:masterfrom
Haxx0r-4559:patch-1
Aug 17, 2022
Merged

Fix logged group name in reinforcement check#48
wingzero54 merged 2 commits intoCivMC:masterfrom
Haxx0r-4559:patch-1

Conversation

@Haxx0r-4559
Copy link
Copy Markdown

Untested, but a very simple correction.

Untested, but a very simple correction.
@wingzero54 wingzero54 requested a review from Diet-Cola August 13, 2022 15:04
@Diet-Cola
Copy link
Copy Markdown

Diet-Cola commented Aug 15, 2022

Hi there,

Thank you for contributing! Can you post a screenshot of what the current message is? E.g What it would say in game currently

@Haxx0r-4559
Copy link
Copy Markdown
Author

When in CTR mode with a selected group (in this example, Mta-infra), clicking a block already reinforced on another group lets a player update its group. However, if the player lacks reinforcement permissions on the group which the block is already reinforced on, the following message is sent:

ctr_message

This message is inaccurate, as the group I don't have permission to bypass is the one which the block is reinforced on, not my currently selected CTR group.

@Diet-Cola
Copy link
Copy Markdown

Excellent find, thank you

@Diet-Cola
Copy link
Copy Markdown

Well actually we wouldn't want to expose the group at all since this would be exposing information that shouldn't be exposed right?

@Haxx0r-4559
Copy link
Copy Markdown
Author

That is true. Perhaps the message could be changed to something like "You do not have permission to bypass this reinforcement".

@wingzero54 wingzero54 merged commit b113d85 into CivMC:master Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants