This repository was archived by the owner on Feb 17, 2024. It is now read-only.
Allow multiple acid blocks with different maturation times and faces#56
Merged
AngrySoundTech merged 4 commits intomasterfrom Sep 19, 2022
Merged
Allow multiple acid blocks with different maturation times and faces#56AngrySoundTech merged 4 commits intomasterfrom
AngrySoundTech merged 4 commits intomasterfrom
Conversation
|
now might be a good time to rename |
Diet-Cola
approved these changes
Sep 18, 2022
Diet-Cola
left a comment
Diet-Cola
left a comment
There was a problem hiding this comment.
Solid stuff, comments are just general pointers I've been pulled on before, doesn't block being merged however
| import vg.civcraft.mc.civmodcore.dao.ManagedDatasource; | ||
| import vg.civcraft.mc.civmodcore.utilities.TextUtil; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
Star imports are generally frowned upon
Author
There was a problem hiding this comment.
I blame my editor, will fix
| - DOWN | ||
| netherite: | ||
| material: NETHERITE_BLOCK | ||
| multiplier: 4 |
There was a problem hiding this comment.
Agree with gjum that this is best renamed to maturation_time_multiplier
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.