Skip to content

improved install flow#143

Merged
Huskydog9988 merged 2 commits into
mainfrom
redo-install-flow
Apr 6, 2026
Merged

improved install flow#143
Huskydog9988 merged 2 commits into
mainfrom
redo-install-flow

Conversation

@Huskydog9988
Copy link
Copy Markdown
Contributor

alternative to #142

@Huskydog9988 Huskydog9988 requested a review from Protonull April 6, 2026 18:51
@Protonull
Copy link
Copy Markdown
Collaborator

I'm confused as to what this actually changes. The installation instructions in the new docs/getitng-started.md‎ (typo btw) seem identical to those removed from README.md, so what is actually changing that would've prevented #140?

@Huskydog9988
Copy link
Copy Markdown
Contributor Author

Huskydog9988 commented Apr 6, 2026

The change is that now the compose file actually points to the prebuilt docker image, and it explains how to update the server. Also 140 wouldn't happen because there isn't a prebuilt image for the new version, thus they wouldn't be running a development version.

@Protonull
Copy link
Copy Markdown
Collaborator

Protonull commented Apr 6, 2026

Does Docker have interactive installs/updates though? Or does it just assume that the most-recent prebuilt image is necessarily a newer version?

@Huskydog9988
Copy link
Copy Markdown
Contributor Author

Because of how we have the ci setup, the latest tag is the newest stable version

@Protonull
Copy link
Copy Markdown
Collaborator

Hmmm, I suppose it's fine but I feel like it's inevitable that we're going to get issues in the future about unintended updates (eg: someone wanting to update from 2.2.0-1.21.11 to 2.2.1-1.21.11 but instead updating to 2.3.0-26.1)

@Huskydog9988
Copy link
Copy Markdown
Contributor Author

I think we enforce semantic versioning realistically. But yea that can be an issue. I can add a thing on how docker tags work and how to apply it to the image if we really need that.

@Protonull
Copy link
Copy Markdown
Collaborator

It depends on whether we intend to add multi-version support to the server. If not then yes, please do the docker tag thing.

@Huskydog9988
Copy link
Copy Markdown
Contributor Author

Id prefer if we did do multi version support

@Protonull
Copy link
Copy Markdown
Collaborator

It'd be a lot of work but it's definitely doable. I suppose the question is: what kind of multi-version support are we talking about? Do we maintain a mods for various Minecraft versions, but they're always using the latest protocol. Or do we have the server support outdated mods (ie, readding raw TCP support to the server)?

@Huskydog9988
Copy link
Copy Markdown
Contributor Author

I'm thinking we just support mods (server side) that speak the same protocol version

@Protonull Protonull mentioned this pull request Apr 6, 2026
@Huskydog9988 Huskydog9988 merged commit bc2bd84 into main Apr 6, 2026
@Protonull Protonull deleted the redo-install-flow branch April 6, 2026 22:13
@Protonull Protonull mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants