Revert "Stop shading and relocating Java Websockets (#163)"#166
Merged
Revert "Stop shading and relocating Java Websockets (#163)"#166
Conversation
This reverts commit c33b739.
This makes it clearer as to why this it's even happening: there's something that shouldn't be included in the resulting jar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #163. It turns out that the implicit mod-ification (heh) of the websocket library is more complex than shading and relocating. The
runClienttask is really strange, see #127. But basically, I was unable to find a way to ensure that the websocket library was mod-ified for therunClienttask. As such the client would error out since the version requirement was unmet. It works for production clients because you actually have a build-result jar, rather than the nonsenserunClientdoes.