Stop length-prefixing hashes #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be applied to other things too, of course, but didn't want to de-length-prefix everything at once.
Member
|
How have you tested this? |
Contributor
Author
What do you mean? It's in the specification.
|
Contributor
|
So basically it's just a header you're adding? |
Contributor
Author
|
Quite the opposite, I'm removing header information because the length is already known, so there's no need to prefix the data with its length. |
Contributor
|
Lgtm then. Also why does it only use sha1? Isn't it deprecated? |
Member
SHA1 is guaranteed to be implemented by every JVM, and we don't need any cryptographic capabilities from our hashing function as we only use it for content based indexing with a data size cap. |
Contributor
|
I think this is ready to merge then |
Gjum
approved these changes
Oct 5, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be applied to other things too, of course, but didn't want to de-length-prefix everything at once.