tc_build: tools: Update variable names and assertion message in generate_versioned_binaries()#331
Merged
msfjarvis merged 1 commit intoClangBuiltLinux:mainfrom Apr 17, 2026
Conversation
…ate_versioned_binaries() As pointed out by Harsh in ClangBuiltLinux#330, we are no longer downloading CMakeLists.txt for LLVM's main version, as it was moved to cmake/Modules/LLVMVersion.cmake. Update the variable names and the file name reported to the user to be fully accurate. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
msfjarvis
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by Harsh in #330, we are no longer downloading CMakeLists.txt for LLVM's main version, as it was moved to cmake/Modules/LLVMVersion.cmake. Update the variable names and the file name reported to the user to be fully accurate.