Fix get_managed_event!/2 for events with no leaders
#194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I let you resolve the small conflict on this one before merging 😉 |
raulrpearson
force-pushed
the
fix-get-managed-event
branch
from
f4553f1 to
53275ab
Compare
Contributor
Author
|
Done! |
raulrpearson
force-pushed
the
fix-get-managed-event
branch
from
53275ab to
4c2331b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a quick fix for a bug I spotted just now in development. If you try to check the report for a finished event with no leaders, as the owner of that event, you currently raise an exception. As far as I can tell, this is because the query I wrote for
Events.get_managed_event!/2is producing an empty set when joining with activity leaders. So even though you're the owner of the event, no event is returned in that query. Doing a left join fixes this. Sorry for that!