Skip to content

Download data.parts as bytes in the API#456

Merged
luv-bansal merged 3 commits intomasterfrom
fix_download_url
Dec 3, 2024
Merged

Download data.parts as bytes in the API#456
luv-bansal merged 3 commits intomasterfrom
fix_download_url

Conversation

@luv-bansal
Copy link
Copy Markdown
Contributor

What

  • Since we now have the data.parts proto, which supports multiple images and other inputs in a single request, we also need to downloading them as bytes in the API

Why

How

Tests

Notes

@luv-bansal luv-bansal requested a review from zeiler December 2, 2024 14:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2024

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 79%
clarifai.client 68%
clarifai.client.auth 69%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 83%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 10%
clarifai.runners.models 23%
clarifai.runners.utils 56%
clarifai.schema 100%
clarifai.urls 80%
clarifai.utils 77%
clarifai.utils.evaluation 67%
clarifai.workflows 94%
Summary 63% (3820 / 6057)

Minimum allowed line rate is 50%

Copy link
Copy Markdown
Member

@zeiler zeiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. i'm now wondering if we'll need it on frames or regions? we can leave as is and do in future as needed.

@luv-bansal luv-bansal merged commit 639535b into master Dec 3, 2024
@luv-bansal luv-bansal deleted the fix_download_url branch December 3, 2024 06:57
@srikanthbachala20 srikanthbachala20 mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants