Minor Fixed for Model local testing#469
Merged
luv-bansal merged 1 commit intomasterfrom Dec 19, 2024
Merged
Conversation
Minimum allowed line rate is |
luv-bansal
commented
Dec 19, 2024
Comment on lines
-250
to
-261
| # Terminate any child processes that may have been spawned by the main process | ||
| if process: | ||
| try: | ||
| parent = psutil.Process(process.pid) | ||
| # Get all child processes recursively | ||
| for child in parent.children(recursive=True): | ||
| child.kill() | ||
| except psutil.NoSuchProcess: | ||
| pass | ||
| except Exception as e: | ||
| logger.error(f"Error terminating child processes: {e}") | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Don't think this is needed, because there won't be any child process. Also psutil package won't be available in clarifai package
| labels = sorted(labels.items(), key=lambda x: int(x[0])) | ||
|
|
||
| config_file = os.path.join(self.folder, 'config.yaml') | ||
| self.hf_labels_to_config(labels, config_file) |
Contributor
Author
There was a problem hiding this comment.
This was throwing error when testing image model locally within container because docker don't have permission to change config file. And we don't need this for testing model
zeiler
approved these changes
Dec 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
How
Tests
Notes