Skip to content

[EAGLE-5371] Fix predictions methods#475

Merged
luv-bansal merged 1 commit intomasterfrom
fix-prediction-methods
Jan 10, 2025
Merged

[EAGLE-5371] Fix predictions methods#475
luv-bansal merged 1 commit intomasterfrom
fix-prediction-methods

Conversation

@luv-bansal
Copy link
Copy Markdown
Contributor

What

Issue

Model predictions are failing when using generate_by_bytes and predict_by_bytes methods to make predictions with any community model except for our own model that is configured with a dedicated compute_cluster_id and nodepool_id.

This happens because the generate_by_bytes and predict_by_bytes methods use the model’s user_id to retrieve the compute_cluster_id and nodepool_id resources, but these resources cannot be found under the model’s user_id.

Now user has to pass their user_id in these prediction methods to work

Why

How

Tests

Notes

@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 65%
clarifai.client 67%
clarifai.client.auth 69%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 9%
clarifai.runners.models 16%
clarifai.runners.utils 57%
clarifai.schema 100%
clarifai.urls 80%
clarifai.utils 77%
clarifai.utils.evaluation 67%
clarifai.workflows 94%
Summary 60% (3845 / 6381)

Minimum allowed line rate is 50%

Copy link
Copy Markdown
Contributor

@sainivedh sainivedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for now as temp. fix

@luv-bansal luv-bansal enabled auto-merge (squash) January 10, 2025 11:01
@luv-bansal luv-bansal merged commit 41b0723 into master Jan 10, 2025
@luv-bansal luv-bansal deleted the fix-prediction-methods branch January 10, 2025 11:06
@luv-bansal luv-bansal mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants