[EAGLE-5371] Fix predictions methods#475
Merged
luv-bansal merged 1 commit intomasterfrom Jan 10, 2025
Merged
Conversation
Minimum allowed line rate is |
sainivedh
approved these changes
Jan 10, 2025
Contributor
sainivedh
left a comment
There was a problem hiding this comment.
lgtm for now as temp. fix
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Issue
Model predictions are failing when using
generate_by_bytesandpredict_by_bytesmethods to make predictions with any community model except for our own model that is configured with a dedicated compute_cluster_id and nodepool_id.This happens because the
generate_by_bytesandpredict_by_bytesmethods use the model’s user_id to retrieve thecompute_cluster_idandnodepool_idresources, but these resources cannot be found under the model’s user_id.Now user has to pass their
user_idin these prediction methods to workWhy
How
Tests
Notes