Skip to content

remove triton requirements#490

Merged
zeiler merged 1 commit intomasterfrom
remove-triton-reqs
Jan 21, 2025
Merged

remove triton requirements#490
zeiler merged 1 commit intomasterfrom
remove-triton-reqs

Conversation

@zeiler
Copy link
Copy Markdown
Member

@zeiler zeiler commented Jan 21, 2025

When I removed triton examples I didn't remove their reqs. This will prevent bloat that tritonclient brings with it.

I'd love to get rid of the dependency on numpy as it's large. We could switch to just "np.array" string based type assertions in the several places we expect a numpy type coming in and then maybe inline import numpy. I see it used in a couple of runners thing and eval things but nothing else so it should be possible to remove it ideally as it's a decent sized dependency for the base SDK. Pillow is another that is used for datasets and runners data handler. Wonder if there are flavors of the SDK we can have like clarifai[data] that installs extra stuff like numpy and pillow if you're dealing with evals or want wrappers for runners?

Tabulate and schema are two others that are even less important than numpy. tabulate is only used to log errors in evals @phatvo9 maybe you can remove the need for that?

Schema is some validation stuff maybe @sanjaychelliah you have context on why we need that?

@zeiler zeiler requested a review from luv-bansal January 21, 2025 05:04
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 65%
clarifai.client 71%
clarifai.client.auth 74%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 9%
clarifai.runners.models 27%
clarifai.runners.utils 66%
clarifai.schema 100%
clarifai.urls 80%
clarifai.utils 77%
clarifai.utils.evaluation 67%
clarifai.workflows 94%
Summary 64% (4134 / 6494)

Minimum allowed line rate is 50%

@zeiler zeiler enabled auto-merge (squash) January 21, 2025 14:12
@zeiler zeiler merged commit b473012 into master Jan 21, 2025
@zeiler zeiler deleted the remove-triton-reqs branch January 21, 2025 14:15
@luv-bansal luv-bansal mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants