Conversation
Minimum allowed line rate is |
nitinbhojwani
approved these changes
Jan 21, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I removed triton examples I didn't remove their reqs. This will prevent bloat that tritonclient brings with it.
I'd love to get rid of the dependency on numpy as it's large. We could switch to just "np.array" string based type assertions in the several places we expect a numpy type coming in and then maybe inline import numpy. I see it used in a couple of runners thing and eval things but nothing else so it should be possible to remove it ideally as it's a decent sized dependency for the base SDK. Pillow is another that is used for datasets and runners data handler. Wonder if there are flavors of the SDK we can have like clarifai[data] that installs extra stuff like numpy and pillow if you're dealing with evals or want wrappers for runners?
Tabulate and schema are two others that are even less important than numpy. tabulate is only used to log errors in evals @phatvo9 maybe you can remove the need for that?
Schema is some validation stuff maybe @sanjaychelliah you have context on why we need that?