Skip to content

remove rich from req#560

Merged
sainivedh merged 4 commits intomasterfrom
remove-rich-dependency
May 19, 2025
Merged

remove rich from req#560
sainivedh merged 4 commits intomasterfrom
remove-rich-dependency

Conversation

@sainivedh
Copy link
Copy Markdown
Contributor

@sainivedh sainivedh commented Apr 22, 2025

Why

  • Remove rich as a necessary package in requirements.txt

How

  • Prompt user to install rich when required, such as workflow graph display and dataset upload status

Tests

  • Manual test by observing model upload logs

Notes

@sainivedh sainivedh marked this pull request as ready for review April 22, 2025 07:31
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 43%
clarifai.client 71%
clarifai.client.auth 74%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 10%
clarifai.runners.models 63%
clarifai.runners.utils 60%
clarifai.runners.utils.data_types 77%
clarifai.schema 100%
clarifai.urls 80%
clarifai.utils 74%
clarifai.utils.evaluation 67%
clarifai.workflows 94%
Summary 66% (6051 / 9137)

Minimum allowed line rate is 50%

@sainivedh sainivedh requested a review from sanjaychelliah May 18, 2025 05:20
Copy link
Copy Markdown
Contributor

@sanjaychelliah sanjaychelliah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sainivedh sainivedh merged commit 96f03b2 into master May 19, 2025
9 checks passed
@sainivedh sainivedh deleted the remove-rich-dependency branch May 19, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants