Skip to content

[PR-590] Fix Pythonic bugs#586

Merged
luv-bansal merged 8 commits intomasterfrom
param-class
May 21, 2025
Merged

[PR-590] Fix Pythonic bugs#586
luv-bansal merged 8 commits intomasterfrom
param-class

Conversation

@luv-bansal
Copy link
Copy Markdown
Contributor

@luv-bansal luv-bansal commented May 16, 2025

  • Fix code snippets code

    • for when any of method argument Param(default=None)
    • Included stream method code in snippet
    • corrected code snippets
  • Support (default=None) is Param on client side, currently it isn’t supported

  • Fixed Param Class, before it was not working with openai client

  • Remove use of OutputInfo.params_specs for inference_params

Why

How

Tests

Notes

@luv-bansal luv-bansal marked this pull request as ready for review May 16, 2025 11:34
@luv-bansal luv-bansal changed the title update param class Fix Pythonic bugs May 16, 2025
@luv-bansal luv-bansal changed the title Fix Pythonic bugs [PR-590] Fix Pythonic bugs May 16, 2025
@luv-bansal luv-bansal requested a review from ackizilkale May 16, 2025 12:08
Copy link
Copy Markdown
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fill the details of this PR? Not sure what it is fixing.

ackizilkale

This comment was marked as duplicate.

@luv-bansal luv-bansal requested a review from phatvo9 May 21, 2025 09:56
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 43%
clarifai.client 71%
clarifai.client.auth 74%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 10%
clarifai.runners.models 61%
clarifai.runners.utils 63%
clarifai.runners.utils.data_types 77%
clarifai.schema 100%
clarifai.urls 80%
clarifai.utils 74%
clarifai.utils.evaluation 67%
clarifai.workflows 94%
Summary 66% (6113 / 9211)

Minimum allowed line rate is 50%

@luv-bansal luv-bansal requested a review from ackizilkale May 21, 2025 12:06
@luv-bansal luv-bansal merged commit c4e6f3a into master May 21, 2025
9 checks passed
@luv-bansal luv-bansal deleted the param-class branch May 21, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants