Skip to content

Proactively check code and requirements before upload#625

Merged
zeiler merged 2 commits intomasterfrom
zeiler-improve-linting
Jun 11, 2025
Merged

Proactively check code and requirements before upload#625
zeiler merged 2 commits intomasterfrom
zeiler-improve-linting

Conversation

@zeiler
Copy link
Copy Markdown
Member

@zeiler zeiler commented Jun 11, 2025

I found myself doing lots of simple mistakes uploading lately and we have small fast tools like uv and ruff now that we can use to check quickly before uploading. So added those as requirements. Could also just use them if they are installed and log a warning if they are not in order to keep them minimum.

Fixed bug with AMD base was being used when nvidia was requested.
Fixed bug in openAI code snippet using a non-standard role.

@zeiler zeiler requested a review from luv-bansal June 11, 2025 04:39
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 41%
clarifai.client 71%
clarifai.client.auth 74%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 12%
clarifai.runners.models 62%
clarifai.runners.utils 61%
clarifai.runners.utils.data_types 72%
clarifai.schema 100%
clarifai.urls 58%
clarifai.utils 73%
clarifai.utils.evaluation 67%
clarifai.workflows 94%
Summary 65% (6417 / 9808)

Minimum allowed line rate is 50%

@ackizilkale ackizilkale self-requested a review June 11, 2025 16:36
@zeiler zeiler merged commit b912cec into master Jun 11, 2025
14 of 15 checks passed
@zeiler zeiler deleted the zeiler-improve-linting branch June 11, 2025 16:40
@mogith-pn mogith-pn restored the zeiler-improve-linting branch June 13, 2025 12:20
@mogith-pn mogith-pn deleted the zeiler-improve-linting branch June 13, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants