Skip to content

[PR-743] Improve Local Runner Logging#720

Merged
luv-bansal merged 9 commits intomasterfrom
improve-runner-logging
Jul 30, 2025
Merged

[PR-743] Improve Local Runner Logging#720
luv-bansal merged 9 commits intomasterfrom
improve-runner-logging

Conversation

@luv-bansal
Copy link
Copy Markdown
Contributor

@luv-bansal luv-bansal commented Jul 25, 2025

Improved Local Runner logging based on Alfredo doc: https://docs.google.com/document/d/1AsNSTWPkVlz7I4X2OvsBXRA6439ciBGdYdcs9eK2zIQ/edit?tab=t.0

Pull Request Overview

This PR improves the logging and user experience for the local runner functionality by refactoring requirements parsing, enhancing status messages, and providing better user guidance.

  • Refactored requirements parsing into a dedicated function using proper dependency parsing
  • Enhanced logging with clearer status messages and helpful information for users
  • Reorganized the local runner flow to check requirements earlier and provide better feedback

@luv-bansal luv-bansal requested a review from Copilot July 25, 2025 09:34

This comment was marked as outdated.

@luv-bansal luv-bansal requested a review from Copilot July 25, 2025 09:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the local runner experience by refactoring requirements parsing and enhancing user-facing logging and guidance.

  • Refactored requirements parsing to use proper dependency parsing with the packaging library
  • Enhanced logging throughout the local runner flow with clearer status messages and helpful user guidance
  • Reorganized the local runner workflow to perform requirement checks earlier in the process

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
clarifai/utils/cli.py Refactored requirements parsing into a dedicated function using proper dependency parsing
clarifai/runners/server.py Enhanced logging with helpful user guidance including code snippets and URLs
clarifai/cli/model.py Reorganized local runner flow to check requirements earlier and improved status messages
Comments suppressed due to low confidence (1)

clarifai/utils/cli.py:311

  • [nitpick] The variable name deps is ambiguous. Consider renaming it to dependencies or requirements for better clarity.
    deps = {}

Comment thread clarifai/runners/server.py Outdated
Comment thread clarifai/utils/cli.py Outdated
@luv-bansal luv-bansal changed the title Improve Local Runner Logging [PR-743] Improve Local Runner Logging Jul 25, 2025
Comment thread clarifai/cli/model.py
Comment thread clarifai/cli/model.py
Comment thread clarifai/runners/server.py Outdated
Comment thread clarifai/cli/model.py
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 42%
clarifai.cli.templates 28%
clarifai.client 69%
clarifai.client.auth 67%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 10%
clarifai.runners.models 59%
clarifai.runners.pipeline_steps 45%
clarifai.runners.pipelines 85%
clarifai.runners.utils 62%
clarifai.runners.utils.data_types 72%
clarifai.schema 100%
clarifai.urls 60%
clarifai.utils 53%
clarifai.utils.evaluation 67%
clarifai.workflows 95%
Summary 62% (7407 / 11991)

Minimum allowed line rate is 50%

Copy link
Copy Markdown
Contributor

@srikanthbachala20 srikanthbachala20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luv-bansal luv-bansal merged commit 60ab682 into master Jul 30, 2025
11 checks passed
@luv-bansal luv-bansal deleted the improve-runner-logging branch July 30, 2025 10:16
@luv-bansal luv-bansal mentioned this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants