pipeline_steps should be used in templates#728
Merged
Conversation
patricklundquist
approved these changes
Aug 1, 2025
Member
Author
|
@copilot fix the tests please |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the API to consistently use pipeline_steps instead of pipeline-steps in templates and configurations. This change addresses inconsistencies in the API naming convention and fixes a bug where old version IDs in config.yaml caused "step name not defined" errors.
- Standardizes template reference patterns from
pipeline-stepstopipeline_stepsacross test files, validation logic, and templates - Updates pipeline builder to treat missing step directories as an error rather than success to prevent confusion
- Improves error handling and logging by converting protobuf messages to dictionaries for better readability
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/cli/test_pipeline.py | Updates test cases to use pipeline_steps instead of pipeline-steps in template references |
| clarifai/runners/utils/pipeline_validation.py | Updates regex patterns and error messages to validate pipeline_steps naming convention |
| clarifai/runners/pipelines/pipeline_builder.py | Changes return value for empty step directories and refactors template reference version updating logic |
| clarifai/client/pipeline.py | Adds protobuf-to-dict conversion for better logging and enhanced error handling for missing pipelines |
| clarifai/cli/templates/pipeline_templates.py | Updates pipeline config template to use pipeline_steps naming convention |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ifai-python into zeiler-more-pipeline-fixes
Minimum allowed line rate is |
nitinbhojwani
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be consistent with our API in using pipeline_steps not pipeline-steps in the templates.
This make upload require some steps to upload for now so avoid confusion until lock is implemented.
This updates the version IDs for existing template that have versions to make sure the config.yaml is always the final one uploaded. This caused a hard to understand bug about step name not being defined from the API when it had an old version ID in the config.yaml (which I guess was also in the uploaded API representation from pl upload).
Also improved logging by using proto to dict.