Skip to content

[EAGLE-6618]: Fix num_threads setting#752

Merged
zeiler merged 1 commit intomasterfrom
EAGLE-6618-fix-num-threads
Aug 19, 2025
Merged

[EAGLE-6618]: Fix num_threads setting#752
zeiler merged 1 commit intomasterfrom
EAGLE-6618-fix-num-threads

Conversation

@zeiler
Copy link
Copy Markdown
Member

@zeiler zeiler commented Aug 19, 2025

We were always setting num_threads to 10 since a recent change because we passed the argparse results as args and not kwargs.

@zeiler zeiler requested a review from Copilot August 19, 2025 16:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a bug where the num_threads setting was not being properly passed to the serve function due to using positional arguments instead of keyword arguments when calling the function from the argument parser results.

  • Changed the serve function call to use keyword arguments instead of positional arguments
  • Updated help text to clarify num_threads behavior for different server modes
  • Version bump to 11.7.2

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
clarifai/runners/server.py Fixed argument passing to serve function and improved help text
clarifai/init.py Version bump to 11.7.2
CHANGELOG.md Added changelog entry for the fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread clarifai/runners/server.py
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 43%
clarifai.cli.templates 28%
clarifai.client 67%
clarifai.client.auth 67%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 9%
clarifai.runners.models 59%
clarifai.runners.pipeline_steps 45%
clarifai.runners.pipelines 80%
clarifai.runners.utils 62%
clarifai.runners.utils.data_types 72%
clarifai.schema 100%
clarifai.urls 60%
clarifai.utils 53%
clarifai.utils.evaluation 67%
clarifai.workflows 95%
Summary 61% (7558 / 12300)

Minimum allowed line rate is 50%

@zeiler zeiler merged commit aa3e0c6 into master Aug 19, 2025
11 checks passed
@zeiler zeiler deleted the EAGLE-6618-fix-num-threads branch August 19, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants