Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug where the num_threads setting was not being properly passed to the serve function due to using positional arguments instead of keyword arguments when calling the function from the argument parser results.
- Changed the
servefunction call to use keyword arguments instead of positional arguments - Updated help text to clarify num_threads behavior for different server modes
- Version bump to 11.7.2
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| clarifai/runners/server.py | Fixed argument passing to serve function and improved help text |
| clarifai/init.py | Version bump to 11.7.2 |
| CHANGELOG.md | Added changelog entry for the fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were always setting num_threads to 10 since a recent change because we passed the argparse results as args and not kwargs.