Skip to content

[PR-884] Add Secrets CRUD Operations and Integrate secretes with Model Upload#779

Merged
luv-bansal merged 4 commits intomasterfrom
secrete
Sep 16, 2025
Merged

[PR-884] Add Secrets CRUD Operations and Integrate secretes with Model Upload#779
luv-bansal merged 4 commits intomasterfrom
secrete

Conversation

@luv-bansal
Copy link
Copy Markdown
Contributor

@luv-bansal luv-bansal commented Sep 9, 2025

Pull Request Overview

This PR adds comprehensive secrets management functionality to Clarifai's client, including CRUD operations for secrets and integration with model upload workflows. It allows users to define secrets in configuration files that are automatically validated, created, and attached to model versions during upload.

  • Adds complete secrets CRUD operations (create, read, update, delete, list) to the User client
  • Integrates secrets validation and processing into the model builder workflow
  • Adds configuration validation for secrets defined in model config files

@luv-bansal luv-bansal requested a review from Copilot September 9, 2025 11:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive secrets management functionality to Clarifai's client, including CRUD operations for secrets and integration with model upload workflows. It allows users to define secrets in configuration files that are automatically validated, created, and attached to model versions during upload.

  • Adds complete secrets CRUD operations (create, read, update, delete, list) to the User client
  • Integrates secrets validation and processing into the model builder workflow
  • Adds configuration validation for secrets defined in model config files

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
clarifai/client/user.py Implements five new methods for secrets management: get_secret, list_secrets, create_secrets, patch_secrets, and delete_secrets
clarifai/runners/models/model_builder.py Adds secrets validation and processing logic to validate config secrets and integrate them into model version creation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread clarifai/runners/models/model_builder.py Outdated
Comment thread clarifai/runners/models/model_builder.py Outdated
Comment thread clarifai/runners/models/model_builder.py Dismissed
Comment thread clarifai/runners/models/model_builder.py Dismissed
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 41%
clarifai.cli.templates 36%
clarifai.client 67%
clarifai.client.auth 67%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 53%
clarifai.runners.models 58%
clarifai.runners.pipeline_steps 44%
clarifai.runners.pipelines 80%
clarifai.runners.utils 63%
clarifai.runners.utils.data_types 72%
clarifai.schema 100%
clarifai.urls 60%
clarifai.utils 57%
clarifai.utils.evaluation 67%
clarifai.workflows 95%
Summary 61% (7892 / 12860)

Minimum allowed line rate is 50%

@luv-bansal luv-bansal changed the title Add Secrets CRUD Operations and Integrate secretes with Model Upload [PR-884] Add Secrets CRUD Operations and Integrate secretes with Model Upload Sep 11, 2025
@luv-bansal luv-bansal merged commit c78b818 into master Sep 16, 2025
10 of 11 checks passed
@luv-bansal luv-bansal deleted the secrete branch September 16, 2025 08:04
@srikanthbachala20 srikanthbachala20 mentioned this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants