[PR-884] Add Secrets CRUD Operations and Integrate secretes with Model Upload#779
Merged
luv-bansal merged 4 commits intomasterfrom Sep 16, 2025
Merged
[PR-884] Add Secrets CRUD Operations and Integrate secretes with Model Upload#779luv-bansal merged 4 commits intomasterfrom
luv-bansal merged 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive secrets management functionality to Clarifai's client, including CRUD operations for secrets and integration with model upload workflows. It allows users to define secrets in configuration files that are automatically validated, created, and attached to model versions during upload.
- Adds complete secrets CRUD operations (create, read, update, delete, list) to the User client
- Integrates secrets validation and processing into the model builder workflow
- Adds configuration validation for secrets defined in model config files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| clarifai/client/user.py | Implements five new methods for secrets management: get_secret, list_secrets, create_secrets, patch_secrets, and delete_secrets |
| clarifai/runners/models/model_builder.py | Adds secrets validation and processing logic to validate config secrets and integrate them into model version creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Minimum allowed line rate is |
wemoveon2
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR adds comprehensive secrets management functionality to Clarifai's client, including CRUD operations for secrets and integration with model upload workflows. It allows users to define secrets in configuration files that are automatically validated, created, and attached to model versions during upload.