[EAGLE-6930] Add platform specification to config.yaml for model versions#855
Merged
[EAGLE-6930] Add platform specification to config.yaml for model versions#855
Conversation
- Read platform from config.yaml build_info section - Set platform on model_version.build_info when protobuf field is available - Add forward-compatible code with graceful fallback - Update templates to include platform example - Add comprehensive tests for platform configuration Co-authored-by: wemoveon2 <86081107+wemoveon2@users.noreply.github.com>
- Add clarifying comment for empty string check in platform validation - Improve test model to actually process input text - Ensure code quality and maintainability Co-authored-by: wemoveon2 <86081107+wemoveon2@users.noreply.github.com>
Contributor
|
@copilot instead of writing new tests, modify an existing test doing PostModelVersionsUpload and add amd and arm to the specifications. confirm the model was built for the platforms with a GetModelVersions request like |
- Remove standalone test_build_info_platform.py test file - Add platform specification to dummy_models_path fixture - Add GetModelVersion verification in test_model_uploader_flow - Verify platform is set to "linux/amd64,linux/arm64" Co-authored-by: wemoveon2 <86081107+wemoveon2@users.noreply.github.com>
Contributor
Author
Done! I've modified the existing test_model_uploader_flow test instead of creating a new test file. The changes include:
Changes in commit 3563f2c |
Co-authored-by: wemoveon2 <86081107+wemoveon2@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add platform specification to config.yaml for model versions
Add platform specification to config.yaml for model versions
Nov 24, 2025
Minimum allowed line rate is |
wemoveon2
approved these changes
Nov 24, 2025
patricklundquist
approved these changes
Nov 24, 2025
ackizilkale
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The API now supports specifying target platform(s) for Docker image builds (e.g.,
linux/amd64,linux/arm64), but the Python SDK didn't expose this capability to users through the config.yaml file.How
platformfromconfig.yamlunderbuild_infosectionmodel_version.build_info.platforminget_model_version_proto()when field exists in protobufTests
test_model_uploader_flowintegration test to include platform specificationNotes
Example usage:
Requires clarifai-grpc update with
BuildInfo.platformfield for full functionality. Until then, feature degrades gracefully with warning.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.