Fix TypeError when accelerator_type is None in config.yaml#864
Merged
ackizilkale merged 1 commit intomasterfrom Dec 3, 2025
Merged
Fix TypeError when accelerator_type is None in config.yaml#864ackizilkale merged 1 commit intomasterfrom
ackizilkale merged 1 commit intomasterfrom
Conversation
- Add null check before iterating over accelerator_type - Prevents 'NoneType' object is not iterable error during model upload - Handles cases where accelerator_type is explicitly set to null in config
wemoveon2
approved these changes
Dec 3, 2025
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The
_is_amd()method checks if theaccelerator_typekey exists but doesn't validate that its value is notNonebefore attempting to iterate over it.Solution
Added a null/empty check before iterating over
accelerator_type:accelerator_typevalue is notNoneor emptyaccelerator_typeis explicitly set tonullTesting
accelerator_type: nullcorrectlyImpact
accelerator_type: nullin config.yamlFixes the model upload workflow for CPU-only models.