Skip to content

fix: align test assertion for all-failed stream outputs with actual status code#997

Merged
patricklundquist merged 2 commits intobolt-runner-perf-optimizations-240856538465656847from
copilot/sub-pr-994
Mar 19, 2026
Merged

fix: align test assertion for all-failed stream outputs with actual status code#997
patricklundquist merged 2 commits intobolt-runner-perf-optimizations-240856538465656847from
copilot/sub-pr-994

Conversation

Copy link
Contributor

Copilot AI commented Mar 19, 2026

test_all_failed_outputs in TestRunnerItemStreamStatus was asserting FAILURE but runner_item_stream emits RUNNER_PROCESSING_FAILED when all outputs fail — causing a CI failure.

Why

Test assertion did not match the actual status code emitted by runner_item_stream on total output failure.

How

Updated the assertion in TestRunnerItemStreamStatus::test_all_failed_outputs from status_code_pb2.FAILURE to status_code_pb2.RUNNER_PROCESSING_FAILED.

Tests

All 13 unit tests in tests/runners/test_model_runner_unit.py pass.

Notes


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…iled stream outputs

Co-authored-by: patricklundquist <1460278+patricklundquist@users.noreply.github.com>
Copilot AI changed the title [WIP] Optimize model runner memory and latency fix: align test assertion for all-failed stream outputs with actual status code Mar 19, 2026
Copilot AI requested a review from patricklundquist March 19, 2026 20:21
@patricklundquist patricklundquist marked this pull request as ready for review March 19, 2026 21:44
@patricklundquist patricklundquist merged commit f6b0014 into bolt-runner-perf-optimizations-240856538465656847 Mar 19, 2026
1 check passed
@patricklundquist patricklundquist deleted the copilot/sub-pr-994 branch March 19, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants