fix(vulnerability_map.py): precision issues #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @agcopenhaver, thank you for identifying the precision issue. I agree that risk_class[n_classes-1][1] can experience precision problems with the default float64 datatype. Also, since risk_class[0][0] will naturally be set to NRT due to x[0][0] being 1, it might be cleaner to remove the explicit assignment |
Member
|
Since the statement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly setting llmin and llmax, cleanup reclass to make it flexible if n_classes changes and more readable using a loop.
Fixes the problem noted in #31.
I'd also like to change the alternative approach accordingly as well. But wanted to keep this PR small.