Php 8.2 update + changes from remote repository #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated composer.json
…r PHPUnit versions.
- add missing parameters - fixed missing spaces - fixed typo
- Issue raise here https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:285 - Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test - Rollback line code to here https://github.com/hungtrinh/zf1-future/blob/5ae9f922ca97bd59a7f70e5c2efb10b360eae331/tests/Zend/Db/Statement/TestCommon.php#L825
Issue raise here: https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:635 Zend_Db_Statement_Pdo_SqliteTest::testStatementGetSetAttribute Failed asserting that 'SQLSTATE[IM001]: Driver does not support this function: driver doesn't support getting that attribute' contains "This driver doesn't support getting". - with pdo_mysql will raise this message https://github.com/php/php-src/blob/568ed4721e6dffd8085c04552a3b24d0057ed2fe/ext/pdo/pdo_stmt.c#L1626 - with pdo_sqlite will raise this message https://github.com/php/php-src/blob/568ed4721e6dffd8085c04552a3b24d0057ed2fe/ext/pdo/pdo_stmt.c#L1642
- Issue raise here https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:279 - Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test - Rollback line code to here https://github.com/hungtrinh/zf1-future/blob/5ae9f922ca97bd59a7f70e5c2efb10b360eae331/tests/Zend/Db/Adapter/TestCommon.php#L791
PHPUnit <= 6.x: true === assertEquals('12.34','12.340000')
Since PHPUnit 7.x: false === assertEquals('12.34','12.340000')
- Issue raise here https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:293 - Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test - Rollback line code to here https://github.com/Shardj/zf1-future/blob/5ae9f922ca97bd59a7f70e5c2efb10b360eae331/tests/Zend/Db/Select/TestCommon.php#L316-L333
- Issue raise here: https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:360 - Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test - Rollback line code to here https://github.com/Shardj/zf1-future/blob/31ba05039cc0485b4cf9c5dfc7284cd4d185cd5e/tests/Zend/Db/Table/TestCommon.php#L224
- Issue raise here: https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:307 - Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test - Rollback line code to here https://github.com/Shardj/zf1-future/blob/31ba05039cc0485b4cf9c5dfc7284cd4d185cd5e/tests/Zend/Db/Table/TestCommon.php#L235
- Issue raise here: https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:314 - Root Cause: migrate from PHPUnit 3.x to PHPUnit 9.x by Rector tool without cover by ci db test - Rollback line code to here https://github.com/Shardj/zf1-future/blob/31ba05039cc0485b4cf9c5dfc7284cd4d185cd5e/tests/Zend/Db/Table/TestCommon.php#L247
Issue raise here: - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:320 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:380 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:440 Root Cause: PHPUnit Expected user notice changed when migrate PHPUnit 3.x => PHPUnit 9.x
Correctly test code to match with this commit Shardj@ad81d0c Issue raise here: - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:4824 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:558 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:641 Root cause here: - Shardj@ad81d0c#r92247133 - Shardj@ad81d0c#r92248282
Issue raise here: - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:752 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:760 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:768 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:776 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:784
Issue raise here: - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:708 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:714 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:720 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:726 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:732 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:738
Issue raise here: - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:816 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:822 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:828 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:834 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:840 - https://github.com/hungtrinh/zf1-future/actions/runs/3646749004/jobs/6158176190#step:7:846
As of PHP 8, PDO::rollback() will throw a There is no active transaction PDOException if the transaction had been autocommitted, as MySQL will do whenever a schema change is made. Previously they would fail silently.
…ck-like-php7 Pdo transaction bring back like php7
…derFix sendmail header sanitization quick-fix, as described in Shardj#326
Versioning fix
In order to accomplish successful passing of tests in all supported PHP versions: - Removed a few instances of erroneous doesNotPerformAssertions annotations. - Changed the detection from "apc" to "apcu". - Added protection for classes unserialization in TwoLevels cache and made it remove the ID from either cache if it was corrupted at rest. - Fixed the testSaveOverwritesIfFastIsFull() method to only partially mock the fast cache. Specifically, mock only the getFillingPercentage() method, and still really execute the rest, rather than just return NULL, which in turn caused the test to fail. - Added debug logs in TwoLevels cache, and warnings in File cache on errors.
Enabled testing of APCU for all PHP versions when running with all extensions enabled
Fixed a minor error with translating full dates to the Finnish language
Finnish date translations
…lidationRework addressed 5th sendmail param validation using -f (Shardj#326)
version bump 1.23.3
…tWrongCoparsion Sendmail transport - wrong comparison fix
…ToSendmail further Zend Mail sendmail transport validation tweak
# Conflicts: # library/Zend/Mail/Transport/Sendmail.php # tests/Zend/DateTest.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.