Add Windows CI build too by ClausKlein · Pull Request #2 · ClausKlein/scope

ClausKlein · 2026-01-10T17:52:22Z

This offers a portable implementation version that compiles on all OS with all C++23 compilers

Refactory CXX_MODULE according to Daniela advice
Quickfix: do not use the old implementation
Autoupdate pre-commit hooks
Use import std; too
Build always an interface library

TODO:

Windows DLL no lib found
Linker problems with gcc on OSX
Liner problems with clang Debug on CI

NOTE: This version compiles on OSX with apple-clang, llvm-clang, and g++-15 too!

Following Issues will be fixed:

I have been prepared export headers to test with DLL's on Windows too.

see https://discourse.cmake.org/t/linker-error-with-cxx-modules/15449

and portable C++ feature checks

This compiles with clang++-21 on OSX and should build on Windows too.

coveralls · 2026-01-11T21:04:29Z

Pull Request Test Coverage Report for Build 22622218215

Details

26 of 27 (96.3%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.7%) to 96.296%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
include/beman/scope/scope_impl.hpp	26	27	96.3%

Totals
Change from base Build 22584283472:	-3.7%
Covered Lines:	26
Relevant Lines:	27

💛 - Coveralls

Add more test for unique_resource

ClausKlein · 2026-01-13T20:09:41Z

Note: Line coverage is only in range of about 95 - 97 % !

bash-5.3$ make coverage
mkdir -p build/coverage
gcovr # XXX -v
(INFO) Reading coverage data...
(INFO) Writing coverage report...
lines: 95.3% (241 out of 253)
functions: 100.0% (173 out of 173)
branches: 49.8% (131 out of 263)
bash-5.3$

scope_exit does not need to be move-assignable!

add get_version() to CXX_MODULE to export some code;

This is needed if only an interface library is build

Prevent warning: placeholder variables are a C++2c extension

JeffGarland · 2026-01-19T16:15:22Z

include/beman/scope/scope.hpp


-#include <experimental/scope> //todo unconditional for unique_resource
+// detect standard header first, then experimental, otherwise use local implementation
+#if defined(__has_include)


This is c++17 feature so we don't need an existence check as the above code will already handle that we're 20+

JeffGarland · 2026-01-19T16:15:47Z

include/beman/scope/scope.hpp

-#include <experimental/scope> //todo unconditional for unique_resource
+// detect standard header first, then experimental, otherwise use local implementation
+#if defined(__has_include)
+#  if __has_include(<scope>)


No implementation has this header - so this isn't needed.

JeffGarland · 2026-01-19T16:17:00Z

include/beman/scope/scope.hpp

+#  else
+// no std scope header — fall through to local implementation below
+#  endif
+#elif defined(__cpp_lib_scope) && __cpp_lib_scope >= 2023xxxxL


again - this doesn't exist at all

JeffGarland · 2026-01-19T16:22:05Z

include/beman/scope/scope_impl.hpp

@@ -0,0 +1,330 @@
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception


I'd really prefer the implementation to stay in scope.hpp

Do I understand right: I should do git mv scope_impl.hpp scope.hpp ?

JeffGarland · 2026-01-19T16:24:00Z

include/beman/scope/scope_impl.hpp

+#  error "C++20 or later is required"
+#endif
+
+// detect standard header first, then experimental, otherwise use local implementation


I think now is the time to use the local first and only use experimental on request - aka a cmake override

JeffGarland · 2026-01-19T16:25:36Z

include/beman/scope/scope_impl.hpp

+    // Move assignment
+    constexpr auto operator=(scope_success&& other) noexcept(std::is_nothrow_move_assignable_v<F>)
+        -> scope_success& = delete;
+#if MOVE_ASSIGNMENT_NEEDED


Lets use concepts -- in 2026 I don't want macros for this

I have tried to test them, the move assignment does not work and is not needed I think.

JeffGarland · 2026-01-19T16:26:33Z

My review is incomplete, but I'm out of time for now

ClausKlein · 2026-01-19T21:35:30Z

include/beman/scope/scope_impl.hpp

+    // TODO(CK): missing usecase?
+    constexpr auto get_deleter() const noexcept -> Deleter;
+
+    // Helper to tests is_active()
+    // NOTE: check if active; not required from LWG?
+    constexpr explicit operator bool() const noexcept { return active; }


include/beman/scope/scope_impl.hpp

Quickfix: do not use the old implementation Autoupdate pre-commit hooks

CMAKE_EXPERIMENTAL_CXX_IMPORT_STD is still needed Build and install always a header only lib Fix some clang-tidy warnings pre-commit autoupdate

Add Windows CI build too

459fbdc

ClausKlein self-assigned this Jan 10, 2026

Use portable C++20 check

f3c5c4a

and portable C++ feature checks

ClausKlein force-pushed the feature/add-windows-ci branch from ab326ee to f3c5c4a Compare January 10, 2026 18:19

ClausKlein added 2 commits January 10, 2026 19:35

Use C++23 on Windows

9ad29b7

Quickfix to compile with C++23

01a4dcf

ClausKlein force-pushed the feature/add-windows-ci branch from 3415d2e to 01a4dcf Compare January 10, 2026 19:23

Add simple BEMAN_SCOPE_USE_FALLBACK code

6f75603

This compiles with clang++-21 on OSX and should build on Windows too.

ClausKlein added 2 commits January 11, 2026 22:23

Fix Windows CI test directory

d83e3f4

Refactory unique_resource code to be portable

2f5ab94

Add more test for unique_resource

ClausKlein force-pushed the feature/add-windows-ci branch from f827b5d to 2f5ab94 Compare January 13, 2026 20:05

ClausKlein added 4 commits January 13, 2026 21:36

Prevent use of explicit operator bool() const noexcept

4a9894d

Test appleclang on CI too

7d92b09

Deleted move assignment operators

58335ff

scope_exit does not need to be move-assignable!

Try to BUILD_SHARED_LIBS on windows

1a86a99

add get_version() to CXX_MODULE to export some code;

ClausKlein force-pushed the feature/add-windows-ci branch from 350bcd8 to 1a86a99 Compare January 15, 2026 21:05

ClausKlein added 2 commits January 15, 2026 23:38

Use GenerateExportHeader cmake module

8c63627

Quickfix for missing export header

f51bfa4

This is needed if only an interface library is build

ClausKlein force-pushed the feature/add-windows-ci branch from 79cd72c to f51bfa4 Compare January 16, 2026 23:09

ClausKlein added 2 commits January 17, 2026 16:23

Use ctest --build-and-test to check the installed version

c9197e6

The final cut

7af734d

Prevent warning: placeholder variables are a C++2c extension

ClausKlein force-pushed the feature/add-windows-ci branch from 26120f1 to 7af734d Compare January 17, 2026 18:52

Prevent use of std::print() for now

3c99179

JeffGarland reviewed Jan 19, 2026

View reviewed changes

ClausKlein commented Jan 19, 2026

View reviewed changes

include/beman/scope/scope_impl.hpp Show resolved Hide resolved

ClausKlein requested a review from JeffGarland January 19, 2026 21:41

ClausKlein added 2 commits January 27, 2026 11:32

Add infra submodule and use it

9b63207

infra/tools/beman-submodule/beman-submodule update

38f5da3

ClausKlein force-pushed the feature/add-windows-ci branch from 86c2cfa to c0e2002 Compare February 27, 2026 10:15

Refactory CXX_MODULE according to Daniela advice

3d810f1

Quickfix: do not use the old implementation Autoupdate pre-commit hooks

ClausKlein force-pushed the feature/add-windows-ci branch from 6475182 to 3d810f1 Compare February 27, 2026 20:36

Next steps with import std;

4a35cc4

CMAKE_EXPERIMENTAL_CXX_IMPORT_STD is still needed Build and install always a header only lib Fix some clang-tidy warnings pre-commit autoupdate

ClausKlein force-pushed the feature/add-windows-ci branch from 743105f to 4a35cc4 Compare March 3, 2026 10:31

Try to prevent linker problems on OSX with gcc-15

5c6aa81

ClausKlein requested review from JeffGarland and PeterSommerlad and removed request for JeffGarland March 3, 2026 12:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Windows CI build too#2

Add Windows CI build too#2
ClausKlein wants to merge 21 commits intodevelopfrom
feature/add-windows-ci

ClausKlein commented Jan 10, 2026 •

edited

Loading

Uh oh!

coveralls commented Jan 11, 2026 •

edited

Loading

Uh oh!

ClausKlein commented Jan 13, 2026 •

edited

Loading

Uh oh!

JeffGarland Jan 19, 2026

Uh oh!

JeffGarland Jan 19, 2026

Uh oh!

JeffGarland Jan 19, 2026

Uh oh!

JeffGarland Jan 19, 2026

Uh oh!

ClausKlein Jan 19, 2026

Uh oh!

JeffGarland Jan 19, 2026

Uh oh!

JeffGarland Jan 19, 2026

Uh oh!

ClausKlein Jan 19, 2026

Uh oh!

JeffGarland commented Jan 19, 2026

Uh oh!

ClausKlein Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,330 @@
		// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

Conversation

ClausKlein commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

NOTE: This version compiles on OSX with apple-clang, llvm-clang, and g++-15 too!

I have been prepared export headers to test with DLL's on Windows too.

Uh oh!

coveralls commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 22622218215

Details

💛 - Coveralls

Uh oh!

ClausKlein commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note: Line coverage is only in range of about 95 - 97 % !

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JeffGarland commented Jan 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ClausKlein commented Jan 10, 2026 •

edited

Loading

coveralls commented Jan 11, 2026 •

edited

Loading

ClausKlein commented Jan 13, 2026 •

edited

Loading