Improve rendering/search performance and fix client leaks#153
Merged
Conversation
- Uncap 200 buffer limit - Enable buffering of panels for other search canvases - Reduce duplicate call to setStoredValue() when initializing item/fluid panel slots - Fix scroll position while populating search
- Also fire RenderTooltipEvent.PostBackground
- Refactor bookmarking to BookmarkManager
# Conflicts: # src/main/java/betterquesting/client/gui2/GuiQuestLines.java
WaitingIdly
reviewed
May 11, 2026
WaitingIdly
reviewed
May 11, 2026
WaitingIdly
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has various client-side related improvements to performance.
ItemStackin BQ GUIs by skipping empty text. Previously the text was being drawn twice, even if there was nothing to draw. Example profile of a questline with many quest icons before PR: https://spark.lucko.me/xfvJvzt2z5?hl=2607,80setStoredValue()calls from 2 to 1 inPanelItemSlot.setTooltip()when initializingPanelItemSlot, as it'll be calculated ingetTooltip()on hover anyways.ItemStackcontext to Forge events when rendering tooltips. Previously the events were always being passedItemStack.EMPTY.WorldClientleaks (ports [Memory-opti:fix leak] fix 4 client leaks GTNewHorizons/BetterQuesting#206).BookmarkManager, fixing a leak ofWorldClientif using the quest book in one dimension but not in the current dimension.