Furnace Recipe

[gardenevery]

Summary

Supports setting furnace recipe cooking time and loading furnace recipes from JSON, just like modern versions of Minecraft.

Goals

• Modify FurnaceRecipes to allow registering furnace recipes with different cooking times.
• Modify the TileEntityFurnace.getCookTime() method.
• Discuss and decide on the JSON format for furnace recipes.
• Support loading furnace recipes from JSON.

Non Goals

• Break the current API
• Recipe deletion
• Datapack
• Furnace recipe book

Motivation

1.12.2 cannot define the cooking time for furnace recipes.
1.12.2 cannot register furnace recipes using JSON.

Description

Add a field and a getter method to FurnaceRecipes:

private final Map<ItemStack, Integer> cookTimeList = new HashMap<>();

public int getCookTime(ItemStack stack)
{
    for (Entry<ItemStack, Integer> entry : this.cookTimeList.entrySet())
    {
        if (this.compareItemStacks(stack, entry.getKey()))
        {
            return entry.getValue();
        }
    }
    return 200;
}

Modify the addSmeltingRecipe method in FurnaceRecipes and add the following line:

this.cookTimeList.put(input, 200);

Add overloaded methods:

public void addSmeltingRecipeForBlock(Block input, ItemStack stack, float experience, int time)
{
    this.addSmelting(Item.getItemFromBlock(input), stack, experience, time);
}

public void addSmelting(Item input, ItemStack stack, float experience, int time)
{
    this.addSmeltingRecipe(new ItemStack(input, 1, 32767), stack, experience, time);
}

public void addSmeltingRecipe(ItemStack input, ItemStack stack, float experience, int time)
{
if (getSmeltingResult(input) != ItemStack.EMPTY) { net.minecraftforge.fml.common.FMLLog.log.info("Ignored smelting recipe with conflicting input: {} = {}", input, stack); return; }
    this.smeltingList.put(input, stack);
    this.experienceList.put(stack, experience);
    this.cookTimeList.put(input, time);
}

Change the getCookTime method in TileEntityFurnace to:

public int getCookTime(ItemStack stack)
{
    return FurnaceRecipes.instance().getCookTime(stack);
}

The JSON format is tentatively decided as follows:

{
  "type": "smelting",
  "cookingtime": 200,
  "experience": 0.7,
  "ingredient": "minecraft:iron_ore",
  "result": {
    "id": "minecraft:iron_ingot"
  }
}

{
  "type": "smelting",
  "cookingtime": 200,
  "experience": 0.7,
  "ingredient": {
    "id": "minecraft:iron_ore",
    "data": 0
  },
  "result": {
    "id": "minecraft:iron_ingot",
    "data": 0,
    "count": 1
  }
}

Dependencies

No response

References

No response

Guidelines

• I have and will continue to adhere to the guidelines

[Rongmario]

If possible can you wait on: #584? Furnace (or any) recipes will be best going through this. But thank you for the proposal.

1. Cook time ✅
2. I would like to deprecate FurnaceRecipes class and route all calls into a new manager class somewhere else, but may change with the Strata proposal.
3. JSON format looks good to me ✅

[gardenevery]

1. JSON furnace recipe loading should depend on Strata: Layered Data & Asset Loading System #584
2. For some details, see Furnace optimize #586
3. How to handle wildcards: My idea is that for an item without subtypes, metadata is forced to use 0 for identification
   For items with subtypes, using a wildcard should register all subtypes, and the wildcard in the JSON is "data": 2147483647
   However, there is currently no method to obtain all subtypes of an item
   If the wildcard handling is completed, the data structure will be simplified to Map<ItemKey, SmeltingRecipe>

[Rongmario]

"Wildcard" is denoted with the metadata being MAX_SHORT or 32767

[Wizzerinus]

There's many mods adding their own furnaces, and those would supposedly ignore the cook time, which is kind of un-ideal. (Of course, there's an argument to be made that those mods should be redone, but some can't be due to licensing). What is the intended fix to that as per proposal?