-
-
Notifications
You must be signed in to change notification settings - Fork 32
Rework notifications system #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive rework of the notifications system, migrating from a form-based configuration to a modal-based provider management approach with separate notification providers (Notifiarr and Apprise).
Key changes:
- Rewrote frontend notification settings to use provider-specific modals instead of a single form
- Refactored backend notification architecture to use a provider-based pattern with configuration service
- Updated database schema to support multiple notification providers with separate configurations
Reviewed Changes
Copilot reviewed 65 out of 66 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/docs/configuration/notifications/index.mdx | Added provider configuration documentation |
| code/frontend/src/app/shared/models/ | New TypeScript models for notification providers and enums |
| code/frontend/src/app/settings/notification-settings/ | Complete rewrite to modal-based UI with provider management |
| code/frontend/src/app/core/services/ | New notification provider service and updated documentation service |
| code/backend/Cleanuparr.Persistence/ | Database schema changes for new notification provider architecture |
| code/backend/Cleanuparr.Infrastructure/ | Refactored notification system to use provider factory pattern |
Files not reviewed (1)
- code/backend/Cleanuparr.Persistence/Migrations/Data/20250830230846_ReworkNotificationSystem.Designer.cs: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.