Skip to content

Conversation

@Flaminel
Copy link
Contributor

No description provided.

@Flaminel Flaminel requested a review from Copilot August 31, 2025 19:45

This comment was marked as outdated.

@Flaminel Flaminel requested a review from Copilot September 2, 2025 12:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive rework of the notifications system, migrating from a form-based configuration to a modal-based provider management approach with separate notification providers (Notifiarr and Apprise).

Key changes:

  • Rewrote frontend notification settings to use provider-specific modals instead of a single form
  • Refactored backend notification architecture to use a provider-based pattern with configuration service
  • Updated database schema to support multiple notification providers with separate configurations

Reviewed Changes

Copilot reviewed 65 out of 66 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
docs/docs/configuration/notifications/index.mdx Added provider configuration documentation
code/frontend/src/app/shared/models/ New TypeScript models for notification providers and enums
code/frontend/src/app/settings/notification-settings/ Complete rewrite to modal-based UI with provider management
code/frontend/src/app/core/services/ New notification provider service and updated documentation service
code/backend/Cleanuparr.Persistence/ Database schema changes for new notification provider architecture
code/backend/Cleanuparr.Infrastructure/ Refactored notification system to use provider factory pattern
Files not reviewed (1)
  • code/backend/Cleanuparr.Persistence/Migrations/Data/20250830230846_ReworkNotificationSystem.Designer.cs: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Flaminel Flaminel merged commit f93494a into main Sep 2, 2025
1 check passed
@Flaminel Flaminel deleted the rework_notifications branch September 2, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants