Skip to content

Conversation

@Flaminel
Copy link
Contributor

@Flaminel Flaminel commented Sep 12, 2025

Relates to #178

@Flaminel Flaminel requested a review from Copilot September 12, 2025 23:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds ntfy notification provider support to enable push notifications through the ntfy service. The implementation includes both self-hosted and public ntfy.sh server support with multiple authentication methods and configurable priority levels.

Key changes:

  • Complete ntfy provider implementation with authentication types (None, Basic Auth, Access Token)
  • New documentation pages for notification providers with improved organization
  • Frontend UI updates for PrimeNG component migration and ntfy-specific configuration
  • Backend models, services, and API endpoints for ntfy integration

Reviewed Changes

Copilot reviewed 45 out of 52 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
docs/docs/configuration/notifications/ntfy.mdx New documentation page for ntfy configuration options
docs/docs/configuration/notifications/notifiarr.mdx Extracted Notifiarr documentation to separate page
docs/docs/configuration/notifications/apprise.mdx Extracted Apprise documentation to separate page
docs/docs/configuration/notifications/index.mdx Reorganized to reference separate provider pages
code/frontend/src/styles.scss Updated CSS selectors for PrimeNG component migration
code/frontend/src/app/shared/models/ntfy-*.ts Frontend TypeScript models for ntfy configuration
code/frontend/src/app/settings/notification-settings/modals/ntfy-provider/* New ntfy provider configuration modal component
code/backend/Cleanuparr.Domain/Enums/Ntfy*.cs Backend enum definitions for ntfy authentication and priority
code/backend/Cleanuparr.Persistence/Models/Configuration/Notification/NtfyConfig.cs Database model for ntfy configuration
code/backend/Cleanuparr.Infrastructure/Features/Notifications/Ntfy/* Ntfy notification provider implementation
code/backend/Cleanuparr.Api/Controllers/ConfigurationController.cs API endpoints for ntfy provider CRUD operations
Files not reviewed (1)
  • code/backend/Cleanuparr.Persistence/Migrations/Data/20250912234118_AddNtfy.Designer.cs: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Flaminel Flaminel merged commit cce3bb2 into main Sep 15, 2025
1 check failed
@Flaminel Flaminel deleted the add_ntfy_support branch September 15, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants