Skip to content

Fix float narrowing tests in locales other than en-US #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ClearScriptLib merged 1 commit into from
Oct 8, 2025
Merged

Fix float narrowing tests in locales other than en-US #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ClearScriptTest/JScriptCoreEngineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2958,9 +2958,9 @@ public void JScriptCoreEngine_DisableExtensionMethods()
public void JScriptCoreEngine_DisableFloatNarrowing()
{
engine.AddHostType("StringT", typeof(string));
Assert.AreEqual("123,456.80", engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
Assert.AreEqual(123456.80.ToString("###,###.00"), engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
engine.DisableFloatNarrowing = true;
Assert.AreEqual("123,456.75", engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
Assert.AreEqual(123456.75.ToString("###,###.00"), engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
}

[TestMethod, TestCategory("JScriptCoreEngine")]
Expand Down
4 changes: 2 additions & 2 deletions ClearScriptTest/JScriptEngineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3018,9 +3018,9 @@ public void JScriptEngine_DisableExtensionMethods()
public void JScriptEngine_DisableFloatNarrowing()
{
engine.AddHostType("StringT", typeof(string));
Assert.AreEqual("123,456.80", engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
Assert.AreEqual(123456.80.ToString("###,###.00"), engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
engine.DisableFloatNarrowing = true;
Assert.AreEqual("123,456.75", engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
Assert.AreEqual(123456.75.ToString("###,###.00"), engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
}

[TestMethod, TestCategory("JScriptEngine")]
Expand Down
4 changes: 2 additions & 2 deletions ClearScriptTest/V8ScriptEngineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4620,9 +4620,9 @@ public void V8ScriptEngine_MaxArrayBufferAllocation()
public void V8ScriptEngine_DisableFloatNarrowing()
{
engine.AddHostType("StringT", typeof(string));
Assert.AreEqual("123,456.80", engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
Assert.AreEqual(123456.80.ToString("###,###.00"), engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
engine.DisableFloatNarrowing = true;
Assert.AreEqual("123,456.75", engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
Assert.AreEqual(123456.75.ToString("###,###.00"), engine.Evaluate("StringT.Format('{0:###,###.00}', 123456.75)"));
}

[TestMethod, TestCategory("V8ScriptEngine")]
Expand Down
4 changes: 2 additions & 2 deletions ClearScriptTest/VBScriptCoreEngineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3084,9 +3084,9 @@ class Promise : end class
public void VBScriptCoreEngine_DisableFloatNarrowing()
{
engine.AddHostType("StringT", typeof(string));
Assert.AreEqual("123,456.80", engine.Evaluate("StringT.Format(\"{0:###,###.00}\", 123456.75)"));
Assert.AreEqual(123456.80.ToString("###,###.00"), engine.Evaluate("StringT.Format(\"{0:###,###.00}\", 123456.75)"));
engine.DisableFloatNarrowing = true;
Assert.AreEqual("123,456.75", engine.Evaluate("StringT.Format(\"{0:###,###.00}\", 123456.75)"));
Assert.AreEqual(123456.75.ToString("###,###.00"), engine.Evaluate("StringT.Format(\"{0:###,###.00}\", 123456.75)"));
}

[TestMethod, TestCategory("VBScriptCoreEngine")]
Expand Down
4 changes: 2 additions & 2 deletions ClearScriptTest/VBScriptEngineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3153,9 +3153,9 @@ class Promise : end class
public void VBScriptEngine_DisableFloatNarrowing()
{
engine.AddHostType("StringT", typeof(string));
Assert.AreEqual("123,456.80", engine.Evaluate("StringT.Format(\"{0:###,###.00}\", 123456.75)"));
Assert.AreEqual(123456.80.ToString("###,###.00"), engine.Evaluate("StringT.Format(\"{0:###,###.00}\", 123456.75)"));
engine.DisableFloatNarrowing = true;
Assert.AreEqual("123,456.75", engine.Evaluate("StringT.Format(\"{0:###,###.00}\", 123456.75)"));
Assert.AreEqual(123456.75.ToString("###,###.00"), engine.Evaluate("StringT.Format(\"{0:###,###.00}\", 123456.75)"));
}

[TestMethod, TestCategory("VBScriptEngine")]
Expand Down