Skip to content

initial ianitor version#1

Merged
swistakm merged 7 commits intomasterfrom
feature/initial-ianitor
Oct 30, 2014
Merged

initial ianitor version#1
swistakm merged 7 commits intomasterfrom
feature/initial-ianitor

Conversation

@swistakm
Copy link
Collaborator

code for initial ianitor doorkeeper for easy dynamic registration of services within consul cluster

@swistakm swistakm assigned tomislater, mruwnik and trojkat and unassigned tomislater and mruwnik Oct 28, 2014
setup.py Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove double # -*- coding: utf-8 -*-

@swistakm swistakm assigned trojkat and unassigned trojkat Oct 29, 2014
@swistakm
Copy link
Collaborator Author

I have fixed metioned issues. I have also updated project license and setup.py to match ClearcodeHQ organization.

@swistakm swistakm force-pushed the feature/initial-ianitor branch from fe0e3b9 to 2cca1b3 Compare October 29, 2014 16:00
@swistakm swistakm assigned tomislater and unassigned trojkat Oct 29, 2014
@swistakm
Copy link
Collaborator Author

I have rebased it and pushed with --force since project is in such initial state it should not be an issue.

setup.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember that any package description that should be visible on pypi should be in restructured text than markdown. Otherwise pypi would display raw text.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I know that. I would like to leave it now in this form and maybe add some on-the-fly translation to restructured text on the setup.py upload stage as a separate feature.

Markdown is designed for good readability in verbatim so it's not a bad thing to have plain README.md on pypi.
Also I'm not a big fan of restructured text.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fizyk: I have updated setup.py to convert markdown to rst during package registration/upload.

Results can be seen here: https://pypi.python.org/pypi/ianitor

@swistakm
Copy link
Collaborator Author

Does all approve this pull request?

@fizyk
Copy link
Member

fizyk commented Oct 30, 2014

👍 though would like to see pep258 applied to docstrings ;)

@trojkat
Copy link

trojkat commented Oct 30, 2014

👍 where's the approve button?

@swistakm
Copy link
Collaborator Author

@trojkat there's none 😢

swistakm added a commit that referenced this pull request Oct 30, 2014
@swistakm swistakm merged commit 7093a8b into master Oct 30, 2014
@swistakm swistakm deleted the feature/initial-ianitor branch January 28, 2016 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants