feat: implement comprehensive settings page #123
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a persistent application-wide configuration system, allowing users to customize global preferences such as terminal font, scrollback lines, system monitor refresh rate, and tab close confirmation. A new settings UI has been implemented for managing these preferences, and the application now loads and applies them at runtime. Additionally, tab closing actions can now optionally prompt for confirmation, based on user settings.
New persistent application configuration:
AppConfigstruct with fields for monitor refresh rate, terminal font, scrollback lines, and tab close confirmation, along with load/save functions usingserde_jsonand thedirectoriescrate for cross-platform config storage (src/config_observer.rs). [1] [2]Settings UI implementation:
build_settings_uifunction, providing controls for all configurable options and persisting changes automatically (src/ui/window.rs). [1] [2]Applying configuration at runtime:
AppConfigfor font, scrollback lines, and refresh rate (src/ui/window.rs,src/ui/monitor.rs). [1] [2]Tab close confirmation:
confirm_tab_closesetting inAppConfig(src/ui/window.rs). [1] [2] [3]Supporting dependencies:
serde_jsonas a dependency inCargo.tomlfor config serialization.