fix: resolve Tokio panic and silence logs in SSH askpass mode#147
Merged
Conversation
Cleboost
added a commit
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the startup and AskPass handling logic in
src/main.rsto improve clarity and reliability. The main changes are focused on how logging is initialized and how the AskPass password retrieval flow is handled asynchronously.Improvements to logging and initialization:
RUSTMIUS_ASKPASS_ALIASenvironment variable is set), preventing unnecessary log output during password retrieval.AskPass flow improvements:
write_allandflushto ensure the password is reliably sent to the caller (such as SSH).fix #146