Improve distinct borrow matching and add tests#13
Merged
Clemente90 merged 5 commits intodevelfrom Jan 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
distinctand generic types; normalizing/peeling those wrappers and avoiding instantiation during borrow lookup is required.Description
normalizeBorrowType,baseTypeFromDistinctGeneric,borrowSearchType) and a scoring matcherborrowMatchScoreto preference best overloads when resolving borrows, and integrated them intosearchForBorrowProc(compiler/semcall.nim).inBorrowSearchcontext guard and usingborrowInstTypeto compare types without triggering generic instantiation (compiler/seminst.nim,compiler/semdata.nim).distinct/generic wrappers are collapsed safely when computing borrow compatibility (compiler/seminst.nim,compiler/semcall.nim).tests/distinct/tborrow_nested_distinct_len.nim,tborrow_static_array_nested.nim,tborrow_ref_object.nim, andtborrow_string_concat.nim.Testing
bin/nim c -d:release -r compiler/nim c -d:release -r tests/distinct/tborrow_nested_distinct_len.nim,.../tborrow_static_array_nested.nim,.../tborrow_ref_object.nim, and.../tborrow_string_concat.nim, all of which completed successfully.bin/testament --nim:compiler/nim c tests/distinct, which reported 24 passed and 1 failure; the lone failure is a JS-backend invocation failing because the compiler binary in this environment was not built with the JS backend, not a regression introduced by these changes.Codex Task