Remap borrowed inline iterator symbols in sema, restore strict codegen, and add distinct/borrow runtime tests#15
Merged
Clemente90 merged 1 commit intodevelfrom Jan 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
replaceOwnedSymsand updatesemBorrowincompiler/semstmts.nimso that when an inline iterator is borrowed its body is copied and any symbols owned by the borrowed iterator are remapped to the borrowing iterator.tests/distinct/(tborrow_iterators.nim,tborrow_subclass_methods.nim,tdistinct_language_string.nim,tdistinct_nested.nim).Testing
bin/testament --print --nim:./bin/nim p tests/distinctand all tests intests/distinctpassed (43/43)../koch temp c --hints:off tests/distinct/tborrow_iterators.nimand it completed successfully../koch boot -d:release --skipUserCfg --skipParentCfg --hints:offand it succeeded without error.Codex Task