Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

support oauth tokens#4

Merged
rgarcia merged 5 commits intomasterfrom
token-auth
Apr 30, 2014
Merged

support oauth tokens#4
rgarcia merged 5 commits intomasterfrom
token-auth

Conversation

@rgarcia
Copy link
Copy Markdown
Contributor

@rgarcia rgarcia commented Nov 12, 2013

breaks clever.api_key = "..."

breaks clever.api_key = "..."
@ghost ghost assigned mohit Nov 12, 2013
Comment thread test/test_clever.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone mind if I experiment with doing this using a more pythonic way. I think the behavior to run the same tests in different conditions is possible by using a different test loader and then passing it instances of the class, rather than creating seperate classes for each.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I struggled with changing this test file, so please experiment!

@nathanleiby
Copy link
Copy Markdown
Contributor

@rgarcia can we necromance this PR?

Also, if you don't want to break clever.api_key backwards compatibility, you could make that an alias for ~ "if auth not set then set_api_key else throw exception". But I think it's better to remove it and update the package version appropriately.

@rgarcia
Copy link
Copy Markdown
Contributor Author

rgarcia commented Apr 17, 2014

@nathanleiby sounds good, I'll merge and publish a major version bump shortly

rgarcia added 3 commits April 30, 2014 11:59
Conflicts:
	README.md
	clever/__init__.py
	clever/version.py
	test/test_clever.py
rgarcia added a commit that referenced this pull request Apr 30, 2014
@rgarcia rgarcia merged commit e10ebc0 into master Apr 30, 2014
@rgarcia rgarcia deleted the token-auth branch April 30, 2014 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants