Merged
Conversation
sounds for: - jump (randomly plays one of three sounds) - take damage - die - player spawn Sounds were generated using BFXR https://www.bfxr.net/
peternga
approved these changes
May 8, 2020
peternga
left a comment
peternga
left a comment
There was a problem hiding this comment.
This looks good! We can think about the SoundManager as an addition/upgrade
Assets/Scripts/PlayerAvatar.cs
Outdated
| private BoxCollider2D boxCollider; | ||
| private bool grounded; | ||
| private int hitpoints; | ||
| private bool isDead; |
There was a problem hiding this comment.
Is this just a proxy for hitpoints == 0?
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sounds for:
Sounds were generated using BFXR
https://www.bfxr.net/