Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute sunglasses for fitovers if near/far-sighted #35812

Merged
merged 1 commit into from Dec 2, 2019
Merged

Substitute sunglasses for fitovers if near/far-sighted #35812

merged 1 commit into from Dec 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2019

Summary

SUMMARY: None

Purpose of change

Fixes #35720. Characters shouldn't be dumb enough to buy sunglasses that conflict with their corrective lenses.

Describe the solution

Adds substitutions for near and far-sighted characters that spawn with sunglasses.

Describe alternatives you've considered

Adding a FANCY version of fit-overs for characters that spawn with stylish sunglasses ordinarily.

Testing

Turned Near-Sighted and Far-Sighted off and on in chargen to check inventory.

Additional context

Professional Cyclist, traitless
image
Near-Sighted
image
Far-Sighted
image
Both
image
(Also tested with Bionic Gangster for the regular sunglasses)

@ghost ghost changed the title Substitute sunglasses if near/far-sighted Substitute sunglasses for fitovers if near/far-sighted Dec 2, 2019
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Dec 2, 2019
@ZhilkinSerg ZhilkinSerg merged commit 248b687 into CleverRaven:master Dec 2, 2019
@ghost ghost deleted the GlassesSubstitutes branch December 3, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Characters are able to spawn with 2 pairs of eyewear on
2 participants