Jsonized time to atack skill data #35830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
ZhilkinSerg
commented
Dec 3, 2019
ZhilkinSerg
commented
Dec 3, 2019
ZhilkinSerg
commented
Dec 3, 2019
ZhilkinSerg
commented
Dec 3, 2019
|
Loving this push to jsonize skill information |
ZhilkinSerg
force-pushed
the
jsonize-skill-time-to-attack
branch
2 times, most recently
from
f55b0e6
to
1397402
Compare
ZhilkinSerg
force-pushed
the
jsonize-skill-time-to-attack
branch
2 times, most recently
from
4adec94
to
fe3a96d
Compare
ZhilkinSerg
force-pushed
the
jsonize-skill-time-to-attack
branch
from
fe3a96d
to
ae29a80
Compare
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/new-gun-classes/22972/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Jsonized time to atack skill data "Purpose of change
Allow defining of time to attack data in json for vanilla and mods skills.
Describe the solution
{ "type": "skill", "ident": "smg", ... "time_to_attack": { "min_time": 20, "base_time": 80, "time_reduction_per_level": 10 }, ... },Additional context
#35684 can be closed after current PR is merged and mod author should add a new skill in their mod, e.g.:
{ "type": "skill", "ident": "rifle_bolt_action", "name": "rifles (bolt-action)", "description": "Bolt action is a type of firearm action where the handling of cartridges into and out of the weapon's barrel chamber is operated by manually manipulating the bolt directly via a handle.", "tags": [ "combat_skill" ], "time_to_attack": { "min_time": 60, "base_time": 600, "time_reduction_per_level": 20 }, "display_category": "display_ranged" },