Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More name, weight, and volume updates #35903

Merged
merged 6 commits into from
Dec 7, 2019

Conversation

KorGgenT
Copy link
Member

@KorGgenT KorGgenT commented Dec 6, 2019

Summary

Purpose of change

The purpose of this change is to increase consistency of our Json, and to perhaps deprecate the old style at some point later on.
For names, we use the translation object, which is like so: { "str": string, "str_pl": string }
for volumes, we want to use units strings, and try to keep to larger units when possible:
"750 ml" or "1 L"
similar for weights:
"899 g" or "4 kg" or "28 mg"

Describe the solution

go through the json definitions in the following files:

  • monsters\insect_spider.json
  • monsters\marloss.json
  • monsters\mechsuits.json
  • monsters\mi-go.json
  • monsters\mutant.json

Testing

Loaded the game, observe no errors. then view a couple of entries from each file to see that the name displays properly. Spawn in a few of these and kill them, observing that their corpses did not change in volume or weight.

@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Dec 6, 2019
@ZhilkinSerg ZhilkinSerg merged commit e0f74b7 into CleverRaven:master Dec 7, 2019
@KorGgenT KorGgenT deleted the more-name-updates branch August 13, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants