Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal bridge over air tiles #36703

Closed
wants to merge 3 commits into from
Closed

Conversation

RafeHaab
Copy link
Contributor

@RafeHaab RafeHaab commented Jan 4, 2020

Construction that allows to build metal grates over empty air tiles.

Summary

SUMMARY: Feature "Build metal bridges over open-air tiles"

Purpose of change

By request, I'm adding a way to create metallic bridges that require the tile to be empty air.

Describe the solution

Add a construction project that does it.

Describe alternatives you've considered

Wooden bridges, but someone suggested metal and I liked it better.

Testing

Additional context

Construction that allows to build metal grates over empty air tiles.
@anothersimulacrum
Copy link
Contributor

I don't think these should be added until there's a way to have proper supports.

Co-Authored-By: BevapDin <tho_ki@gmx.de>
@RafeHaab
Copy link
Contributor Author

RafeHaab commented Jan 4, 2020

I don't think these should be added until there's a way to have proper supports.

You need some kind of support to start building on the second level, actually. Else how do you even get there?

@FuelType-Memes
Copy link
Contributor

I think @anothersimulacrum means adding "pre_special": "check_support", otherwise you can build infinitely long metal bridges

@curstwist curstwist added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Jan 6, 2020
Copy link
Member

@kevingranade kevingranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @anothersimulacrum , indefinitely long bridges are not ok, and this (probably accidentally) allows them.

@RafeHaab
Copy link
Contributor Author

Ok, what's failing now?

@FuelType-Memes
Copy link
Contributor

It says right there in the details. For example JSON style check gives this error right at the bottom:

data/json/construction.json needs to be linted
Please read doc/JSON_STYLE.md

"time": "60 m",
"tools": [ [ [ "oxy_torch", 4 ], [ "welder", 20 ], [ "welder_crude", 30 ], [ "toolset", 30 ] ] ],
"qualities": [ [ { "id": "SAW_M", "level": 1 }, { "id": "GLARE", "level": 2 } ] ],
"components": [ [ [ "pipe", 12, "sheet_metal", 1 ] ] ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"components": [ [ [ "pipe", 12, "sheet_metal", 1 ] ] ],
"components": [ [ [ "pipe", 12 ] ], [ [ "sheet_metal", 1 ] ] ],

Copy link
Member

@kevingranade kevingranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine now except for the json load errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants